hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Kanter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9065) JobID.forName() isn't strict enough
Date Thu, 13 Dec 2012 23:44:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531644#comment-13531644
] 

Robert Kanter commented on HADOOP-9065:
---------------------------------------

If you try to kill a job, I don't think you can actually kill a different job because of this
issue; but if you specify an incomplete job id, such as job_201208221603_003 from my example
in the description, it will kill job_201208221603_0003.  When you type job_201208221603_003,
it would presumably be a typo, but we don't know if you meant _0003 (in which case it killed
the right job) or _1003 or _2003 etc (in which case it killed the wrong job).  The patch makes
it so that you have to enter stricter IDs to prevent this.  
                
> JobID.forName() isn't strict enough
> -----------------------------------
>
>                 Key: HADOOP-9065
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9065
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>             Fix For: 1.2.0, 2.0.3-alpha
>
>         Attachments: HADOOP-9065_branch-1.patch, HADOOP-9065.patch
>
>
> If you have a job running as job_201208221603_0003, and then try to kill a job passing
id job_201208221603_003, it will kill job_201208221603_0003 because the last part of the JobID
is parsed as an integer.  We should make JobID.forName() stricter to prevent this and similar
situations as the current behavior isn't so obvious.  
> More specifically, we shouldn't accept JobIDs if the last part of the JobID is:
> {{-}} less than 4 characters (e.g. _003, _123)
> {{-}} more than 4 characters and has a leading zero (e.g. _00003, _01234)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message