hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8957) AbstractFileSystem#IsValidName should be overridden for embedded file systems like ViewFs
Date Tue, 11 Dec 2012 21:25:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529351#comment-13529351
] 

Sanjay Radia commented on HADOOP-8957:
--------------------------------------

bq.  Since RawLocalFileSystem doesn't enforce this [isValidName] ..
You are right - lets keep RawLocalFs consistent with RawLocalFileSystem.
RawLocalFileSystem does allow ':' in path - bin/hadoop fs -mkdir /tmp/x:foo succeeds on a
mac.
(Sorry to ask you to change your patch - it was correct). We can file a separate jira if we
want to enforce this.

+1 on the patch modulo the following
* change RawLocalFs to return true as in your previous patch . Add comment that we rely on
OS checking and that RawLocalFs is consistent with RawLocalFileSystem.
* viewfs#isValidName update comment:
    // Prefix validated at mount time and rest of path validated by mount target.

                
> AbstractFileSystem#IsValidName should be overridden for embedded file systems like ViewFs
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8957
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8957-branch-trunk-win.2.patch, HADOOP-8957-branch-trunk-win.3.patch,
HADOOP-8957.patch, HADOOP-8957.patch
>
>
> This appears to be a problem with parsing a Windows-specific path, ultimately throwing
InvocationTargetException from AbstractFileSystem.newInstance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message