hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Isaacson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8698) Do not call unneceseary setConf(null) in Configured constructor
Date Thu, 06 Dec 2012 23:09:22 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13525986#comment-13525986
] 

Andy Isaacson commented on HADOOP-8698:
---------------------------------------

Can you include the proposed cleanup to remove the unnecessary complexity caused by checking
for null?  Also, after this patch Configured reads:
{code}
...
   public Configured() {
   }
{code}
Why not just delete the method entirely?
                
> Do not call unneceseary setConf(null) in Configured constructor
> ---------------------------------------------------------------
>
>                 Key: HADOOP-8698
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8698
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.23.3, 3.0.0
>            Reporter: Radim Kolar
>            Priority: Minor
>             Fix For: 0.24.0, 3.0.0
>
>         Attachments: setconf-null.txt
>
>
> no-arg constructor of /org/apache/hadoop/conf/Configured calls setConf(null). This is
unnecessary and it increases complexity of setConf() code because you have to check for not
null object reference before using it. Under normal conditions setConf() is never called with
null reference, so not null check is unnecessary.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message