hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8419) GzipCodec NPE upon reset with IBM JDK
Date Mon, 24 Dec 2012 10:08:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539235#comment-13539235
] 

Yu Li commented on HADOOP-8419:
-------------------------------

Thanks Luke for the comments, I have updated and resubmit the patch.

For the updated patch, all test-commit UT passed in my env, and below is the result of test-patch:

{color:green}+1 overall{color}.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.
                
> GzipCodec NPE upon reset with IBM JDK
> -------------------------------------
>
>                 Key: HADOOP-8419
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8419
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 1.0.3
>            Reporter: Luke Lu
>            Assignee: Yu Li
>              Labels: gzip, ibm-jdk
>         Attachments: HADOOP-8419-branch-1.patch, HADOOP-8419-branch1-v2.patch, HADOOP-8419-trunk.patch,
HADOOP-8419-trunk-v2.patch
>
>
> The GzipCodec will NPE upon reset after finish when the native zlib codec is not loaded.
When the native zlib is loaded the codec creates a CompressorOutputStream that doesn't have
the problem, otherwise, the GZipCodec uses GZIPOutputStream which is extended to provide the
resetState method. Since IBM JDK 6 SR9 FP2 including the current JDK 6 SR10, GZIPOutputStream#finish
will release the underlying deflater, which causes NPE upon reset. This seems to be an IBM
JDK quirk as Sun JDK and OpenJDK doesn't have this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message