Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F3AA7D359 for ; Thu, 29 Nov 2012 09:52:59 +0000 (UTC) Received: (qmail 30088 invoked by uid 500); 29 Nov 2012 09:52:59 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 29935 invoked by uid 500); 29 Nov 2012 09:52:59 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 29906 invoked by uid 99); 29 Nov 2012 09:52:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Nov 2012 09:52:58 +0000 Date: Thu, 29 Nov 2012 09:52:58 +0000 (UTC) From: "Ivan A. Veselovsky (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <326735883.39201.1354182778477.JavaMail.jiratomcat@arcas> Subject: [jira] [Created] (HADOOP-9104) Should org.apache.hadoop.fs.DelegationTokenRenewer.addRenewAction(T) reject addition if a renew action for this FS is already present in the queue? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Ivan A. Veselovsky created HADOOP-9104: ------------------------------------------ Summary: Should org.apache.hadoop.fs.DelegationTokenRenewer.addRenewAction(T) reject addition if a renew action for this FS is already present in the queue? Key: HADOOP-9104 URL: https://issues.apache.org/jira/browse/HADOOP-9104 Project: Hadoop Common Issue Type: Improvement Reporter: Ivan A. Veselovsky The issue extrected from discussion in https://issues.apache.org/jira/browse/HADOOP-9046 . Currently the method org.apache.hadoop.fs.DelegationTokenRenewer.addRenewAction(T) allows to add any number of renew actions for the same FS. Question #1: are there real usecases when this can make sense? Also, when we remove a renew action with org.apache.hadoop.fs.DelegationTokenRenewer.removeRenewAction(T), we iterate over all the actions in the queue, and remove the first one with matching FS, if any. So, in case if several actions submitted for the same FS, not more than one action will be removed upon #removeRenewAction() invocation. So, to remove all them a developer will need a cycle. So, if the answer to the question #1 is true, may be we should change the #removeRenewAction(FS) behavior to remove all actions associated with this FS, or add #removeAllRenewActuions(FS)? This is question #2. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira