Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Mon, 26 Nov 2012 20:18:58 +0000 (UTC)
From: "Jing Zhao (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <2065237848.24421.1353961138221.JavaMail.jiratomcat@arcas>
In-Reply-To: <1105066124.119784.1352996172490.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HADOOP-9045) In nodegroup-aware case, make sure
 nodes are avoided to place replica if some replica are already under the
 same nodegroup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504058#comment-13504058 ] 

Jing Zhao commented on HADOOP-9045:
-----------------------------------

The patch looks very good to me. The only concern is that in TestReplicationPolicyWithNodeGroup, 
{noformat}
+      // Enable the checking for stale datanodes in the beginning
+      CONF.setBoolean(DFSConfigKeys.DFS_NAMENODE_CHECK_STALE_DATANODE_KEY, true);
{noformat}
may be unnecessary?
                
> In nodegroup-aware case, make sure nodes are avoided to place replica if some replica are already under the same nodegroup
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9045
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9045
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.0.2-alpha
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: HADOOP-9045.patch, HADOOP-9045-v2.patch, HADOOP-9045-v3.patch, HADOOP-9045-v4.patch
>
>
> In previous implementation for HADOOP-8468, 3rd replica is avoid to place on the same nodegroup of 2nd replica. But it didn't provide check on nodegroup of 1st replica, so if 2nd replica's rack is not efficient to place replica, then it is possible to place 3rd and 1st replica within the same node group. We need a change to remove all nodes from available nodes for placing replica if there already replica on the same nodegroup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira