hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9092) Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
Date Tue, 27 Nov 2012 15:52:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504694#comment-13504694
] 

Robert Joseph Evans commented on HADOOP-9092:
---------------------------------------------

The change looks good.  I have one minor comment still.

in TestJobHistoryEventHandler there is a line where you are using ...+"" to convert something
to a string.  This works, but I would prefer to see something more like Stirng.valueOf(...)
instead.  Other then that I am +1 for the patch.
                
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory 
> -----------------------------------------------------------
>
>                 Key: HADOOP-9092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9092
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: tools
>            Reporter: Aleksey Gorshkov
>         Attachments: HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message