hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8998) send Cache-Control header on JSP pages
Date Wed, 14 Nov 2012 04:26:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496853#comment-13496853
] 

Hadoop QA commented on HADOOP-8998:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553441/HADOOP-8998.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

      {color:red}-1 javac{color}.  The applied patch generated 2029 javac compiler warnings
(more than the trunk's current 2028 warnings).

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1740//testReport/
Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1740//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1740//console

This message is automatically generated.
                
> send Cache-Control header on JSP pages
> --------------------------------------
>
>                 Key: HADOOP-8998
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8998
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Andy Isaacson
>            Assignee: Alejandro Abdelnur
>            Priority: Minor
>         Attachments: HADOOP-8998.patch
>
>
> We should send a Cache-Control header on JSP pages so that HTTP/1.1 compliant caches
can properly manage cached data.
> Currently our JSPs send:
> {noformat}
> % curl -v http://nn1:50070/dfshealth.jsp
> ...
> < HTTP/1.1 200 OK
> < Content-Type: text/html; charset=utf-8
> < Expires: Thu, 01-Jan-1970 00:00:00 GMT
> < Set-Cookie: JSESSIONID=xtblchjm7o7j1y1f33r0mpmqp;Path=/
> < Content-Length: 3651
> < Server: Jetty(6.1.26)
> {noformat}
> Based on a quick reading of RFC 2616 http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html
I think we want to send {{Cache-Control: private, no-cache}} but I could be wrong.  The Jetty
docs http://docs.codehaus.org/display/JETTY/LastModifiedCacheControl indicate this is fairly
straightforward.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message