hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chuan Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9056) Build native library on Windows
Date Tue, 27 Nov 2012 19:41:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504872#comment-13504872
] 

Chuan Liu commented on HADOOP-9056:
-----------------------------------

Looks good in general! I have the following questions and comments.
# It seems this patch only contains changes that made compiling ‘hadoop.dll’ available
on Windows. Some functionality was missing. For example, ‘POSIX.chmod’ was not ported
over from branch-1-win; so were some other IO methods. I also notice some new functions were
introduced in trunk compared with branch-1. For example, posixFadviseIfPossible() and POSIX.posix_fadvis().
What is the plan for those missing functions? Do we plan to port them over in other JIRAs?
# “native.vcxproj.user” file is not needed.
# Snappy does not work on Windows right now. It may be better to exclude snappy related files
from Windows build.
# I think it is better to use ‘WINDOWS’ instead of ‘ _WIN32’ macro in some places
because we explicitly defined the ‘UNIX’ and ‘WINDOWS’ macros in the beginning of
“org_apache_hadoop.h”. It will make it easier in the future if we want to change the definition
of the macros.
# Some changes in SecureIOUtils and Datanode are not ported over. Again I think this is related
to point 1 above.

                
> Build native library on Windows
> -------------------------------
>
>                 Key: HADOOP-9056
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9056
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native
>    Affects Versions: trunk-win
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>             Fix For: trunk-win
>
>         Attachments: HADOOP-9056.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> The native library (hadoop.dll) must be compiled on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message