hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Date Wed, 14 Nov 2012 16:20:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497192#comment-13497192
] 

Robert Joseph Evans commented on HADOOP-9035:
---------------------------------------------

The code looks good to me. About my only comment is that the new isSecurityEnabled(AuthenticationMethod)
is kind of named badly.  It is not really checking if security is enabled, it is checking
to see if a given AuthenticationMethod is enabled or not.  Could you rename it.  I am +1 otherwise.
                
> Generalize setup of LoginContext
> --------------------------------
>
>                 Key: HADOOP-9035
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9035
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for
specific authentication types.  This is inflexible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message