hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8981) TestMetricsSystemImpl fails on Windows
Date Fri, 30 Nov 2012 23:41:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507756#comment-13507756
] 

Luke Lu commented on HADOOP-8981:
---------------------------------

Thanks for the patch Xuan! The patch lgtm besides some minor nits:

# Please add a comment about atMost(2) in the original test to document the intention.
# Please fix the style issues according to https://wiki.apache.org/hadoop/CodeReviewChecklist
** Indentation needs to be 2 spaces, I see 2, 3, 4, 8 being used at the same time :)
                
> TestMetricsSystemImpl fails on Windows
> --------------------------------------
>
>                 Key: HADOOP-8981
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8981
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Arpit Agarwal
>         Attachments: HADOOP-8981-branch-trunk-win.1.patch, HADOOP-8981-branch-trunk-win.2.patch,
HADOOP-8981-branch-trunk-win.3.patch
>
>
> The test is failing on an expected mock interaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message