Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D1C92DA61 for ; Tue, 2 Oct 2012 23:41:08 +0000 (UTC) Received: (qmail 2133 invoked by uid 500); 2 Oct 2012 23:41:08 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 2002 invoked by uid 500); 2 Oct 2012 23:41:08 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 1983 invoked by uid 99); 2 Oct 2012 23:41:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2012 23:41:08 +0000 Date: Wed, 3 Oct 2012 10:41:08 +1100 (NCT) From: "Eli Collins (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <989538544.156936.1349221268433.JavaMail.jiratomcat@arcas> In-Reply-To: <1318449497.26074.1346461327537.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HADOOP-8756) Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468192#comment-13468192 ] Eli Collins commented on HADOOP-8756: ------------------------------------- +1 looks good to me as well For those who haven't been following along, we're segfaulting because the compressor/decompressor ignore failures in initIDS, we now detect this failure and check for it in SnappyCodec so we don't run with snappy when we failed to load it. We still require that libsnappy is present in LD_LIBRARY_PATH (HADOOP-8806 improves how it is located). > Fix SEGV when libsnappy is in java.library.path but not LD_LIBRARY_PATH > ----------------------------------------------------------------------- > > Key: HADOOP-8756 > URL: https://issues.apache.org/jira/browse/HADOOP-8756 > Project: Hadoop Common > Issue Type: Bug > Components: native > Affects Versions: 2.0.2-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HADOOP-8756.002.patch, HADOOP-8756.003.patch, HADOOP-8756.004.patch > > > We use {{System.loadLibrary("snappy")}} from the Java side. However in libhadoop, we use {{dlopen}} to open libsnappy.so dynamically. System.loadLibrary uses {{java.library.path}} to resolve libraries, and {{dlopen}} uses {{LD_LIBRARY_PATH}} and the system paths to resolve libraries. Because of this, the two library loading functions can be at odds. > We should fix this so we only load the library once, preferably using the standard Java {{java.library.path}}. > We should also log the search path(s) we use for {{libsnappy.so}} when loading fails, so that it's easier to diagnose configuration issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira