Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Sat, 27 Oct 2012 18:55:12 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <647223528.35429.1351364112289.JavaMail.jiratomcat@arcas>
In-Reply-To: <2054949592.31000.1351230912417.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HADOOP-8985) Add namespace declarations in
 .proto files for languages other than java
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485484#comment-13485484 ] 

Hudson commented on HADOOP-8985:
--------------------------------

Integrated in Hadoop-trunk-Commit #2934 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2934/])
    HADOOP-8985. Add namespace declarations in .proto files for languages other than java. Thank you Binglin Chan. (Revision 1402845)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1402845
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/HAServiceProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/IpcConnectionContext.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtocolInfo.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcPayloadHeader.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ZKFCProtocol.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto

                
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8985
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ha, ipc
>    Affects Versions: 2.0.2-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this. 
> In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira