Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A9F72DB72 for ; Sat, 27 Oct 2012 18:49:12 +0000 (UTC) Received: (qmail 45573 invoked by uid 500); 27 Oct 2012 18:49:12 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 45546 invoked by uid 500); 27 Oct 2012 18:49:12 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 45527 invoked by uid 99); 27 Oct 2012 18:49:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Oct 2012 18:49:12 +0000 Date: Sat, 27 Oct 2012 18:49:12 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1829754527.35413.1351363752193.JavaMail.jiratomcat@arcas> In-Reply-To: <2054949592.31000.1351230912417.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (HADOOP-8985) Add namespace declarations in .proto files for languages other than java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suresh Srinivas updated HADOOP-8985: ------------------------------------ Resolution: Fixed Fix Version/s: 2.0.3-alpha 3.0.0 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) +1 for the patch. I committed it to trunk and branch-2. Thank you Binglin. > Add namespace declarations in .proto files for languages other than java > ------------------------------------------------------------------------ > > Key: HADOOP-8985 > URL: https://issues.apache.org/jira/browse/HADOOP-8985 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Binglin Chang > Assignee: Binglin Chang > Priority: Minor > Fix For: 3.0.0, 2.0.3-alpha > > Attachments: HADOOP-8985-add-namespace.patch > > > Currently .proto files use java_package to specify java packages in proto files, but namespace are not specified for other languages such as cpp, this causes name collision in cpp. we can add namespace declarations to avoid this. > In Java, the package specifier is used as the Java package, unless you explicitly provide a option java_package in your .proto file. So the original java package will not be affected. > About namespace name, how about "hadoop.common"(hadoop::common in cpp) for all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) for all hdfs sub-project proto files? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira