Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 12 Oct 2012 13:07:11 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <1769056216.37067.1350047232001.JavaMail.jiratomcat@arcas>
In-Reply-To: <2030331917.33819.1349998143629.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HADOOP-8918) dev-support/test-patch.sh is
 parsing modified files wrong
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474971#comment-13474971 ] 

Hudson commented on HADOOP-8918:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1193 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1193/])
    HADOOP-8918. test-patch.sh is parsing modified files wrong. Contributed by Raja Aluri. (Revision 1397411)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397411
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

                
> dev-support/test-patch.sh is parsing modified files wrong
> ---------------------------------------------------------
>
>                 Key: HADOOP-8918
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8918
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.2-alpha
>            Reporter: Raja Aluri
>            Assignee: Raja Aluri
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8918.trunk.patch
>
>
> dev-support/test-patch.sh is parsing modified files wrong from the patch.
> In test-patch.sh script, for running findbugs command, it is trying to find out the modified files by doing the following command
> {code}
> $GREP '^+++\|^---' $PATCH_DIR/patch | cut -c '5-' | $GREP -v /dev/null | sort | uniq > $TMP
> {code}
> A patch file can have an entry with xml comments removed, which would match that to be a filename. If you look at the last line of the below text, it would match the filename to be '^M'
> {code}
> -<?xml version="1.0"?>^M
> -<!--^M
> -   Licensed to the Apache Software Foundation (ASF) under one or more^M-   contributor license agreements.  See the NOTICE file distributed with^M
> -   this work for additional information regarding copyright ownership.^M
> -   The ASF licenses this file to You under the Apache License, Version 2.0^M-   (the "License"); you may not use this file except in compliance with^M
> -   the License.  You may obtain a copy of the License at^M
> -^M
> -       http://www.apache.org/licenses/LICENSE-2.0^M
> -^M
> -   Unless required by applicable law or agreed to in writing, software^M
> -   distributed under the License is distributed on an "AS IS" BASIS,^M
> -   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.^M
> -   See the License for the specific language governing permissions and^M
> -   limitations under the License.^M
> --->^M
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira