Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F2754DFEB for ; Wed, 24 Oct 2012 00:54:12 +0000 (UTC) Received: (qmail 12131 invoked by uid 500); 24 Oct 2012 00:54:12 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 12076 invoked by uid 500); 24 Oct 2012 00:54:12 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 11799 invoked by uid 99); 24 Oct 2012 00:54:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Oct 2012 00:54:12 +0000 Date: Wed, 24 Oct 2012 00:54:12 +0000 (UTC) From: "Ivan Mitic (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1214121881.19492.1351040052168.JavaMail.jiratomcat@arcas> In-Reply-To: <1107384818.157717.1349237047837.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HADOOP-8874) HADOOP_HOME and -Dhadoop.home (from hadoop wrapper script) are not uniformly handled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482878#comment-13482878 ] Ivan Mitic commented on HADOOP-8874: ------------------------------------ Thanks John, +1 One minor note, the patch will have to be rebased against latest branch-1-win codebase. > HADOOP_HOME and -Dhadoop.home (from hadoop wrapper script) are not uniformly handled > ------------------------------------------------------------------------------------ > > Key: HADOOP-8874 > URL: https://issues.apache.org/jira/browse/HADOOP-8874 > Project: Hadoop Common > Issue Type: Sub-task > Components: scripts, security > Affects Versions: 1-win > Environment: Called from external process with -D flag vs HADOOP_HOME set. > Reporter: John Gordon > Labels: security > Fix For: 1-win > > Attachments: fix_home_np.patch, HADOOP-8645.1-win.002.patch > > > There is a -D flag to set hadoop.home, which is specified in the hadoop wrapper scripts. This is particularly useful if you want SxS execution of two or more versions of hadoop (e.g. rolling upgrade). However, it isn't honored at all. HADOOP_HOME is used in 3-4 places to find non-java hadoop components such as schedulers, scripts, shared libraries, or with the Windows changes -- binaries. > Ideally, these should all resolve the path in a consistent manner, and callers shuold have a similar onus applied when trying to resolve an invalid path to their components. This is particularly relevant to scripts or binaries that may have security impact, as absolute path resolution is generally safer and more stable than relative path resolution. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira