hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8911) CRLF characters in source and text files
Date Thu, 11 Oct 2012 05:13:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473848#comment-13473848
] 

Suresh Srinivas commented on HADOOP-8911:
-----------------------------------------

If there are no objections by tomorrow, I am going to commit this as a single patch even though
it spans across multiple projects, given this is just removing CRLF characters. I plan to
add appropriate text to describe that this is from a combined patch into CHANGES.txt in each
project.
                
> CRLF characters in source and text files
> ----------------------------------------
>
>                 Key: HADOOP-8911
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8911
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0, 1-win
>            Reporter: Raja Aluri
>         Attachments: HADOOP-8911.branch-1-win.patch, HADOOP-8911.branch-2.patch, HADOOP-8911.trunk.patch,
HADOOP-8911.trunk.patch
>
>
> Source code in hadoop-common repo has a bunch of files that have CRLF endings.
> With more development happening on windows there is a higher chance of more CRLF files
getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from
having CRLF entries in text files.
> But before adding the .gitattributes file we need to normalize the existing tree, so
that people when they sync after .giattributes change wont end up with a bunch of modified
files in their workspace.
> I am adding a couple of links here to give more primer on what exactly is the issue and
how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
> I will submit a separate bug and patch for .gitattributes

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message