hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8929) Add toString for SampleQuantiles
Date Mon, 15 Oct 2012 20:35:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476416#comment-13476416
] 

Todd Lipcon commented on HADOOP-8929:
-------------------------------------

Sorry, should have explained the patch in more detail:

- made it Comparable and changed the HashMap to TreeMap so that the printout is in ascending
percentile order. Given that this map is always very small, and snapshot() is only called
once a minute or so, the runtime/memory differences between treemap and hashmap should be
negligible.
- changed the behavior to return null instead of throw, because all the catching, etc, got
pretty ugly. In implementing toString, I figured I'd clean up the other behavior along the
way.
                
> Add toString for SampleQuantiles
> --------------------------------
>
>                 Key: HADOOP-8929
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8929
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8929.txt
>
>
> The new SampleQuantiles class is useful in the context of benchmarks, but currently there
is no way to print it out outside the context of a metrics sink. It would be nice to have
a convenient way to stringify it for logging, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message