hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8911) CRLF characters in source and text files
Date Fri, 12 Oct 2012 04:23:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474772#comment-13474772
] 

Hadoop QA commented on HADOOP-8911:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548698/HADOOP-8911.trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1618//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1618//console

This message is automatically generated.
                
> CRLF characters in source and text files
> ----------------------------------------
>
>                 Key: HADOOP-8911
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8911
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0, 1-win
>            Reporter: Raja Aluri
>            Assignee: Raja Aluri
>         Attachments: HADOOP-8911.branch-1-win.patch, HADOOP-8911.branch-2.patch, HADOOP-8911.trunk.patch,
HADOOP-8911.trunk.patch
>
>
> Source code in hadoop-common repo has a bunch of files that have CRLF endings.
> With more development happening on windows there is a higher chance of more CRLF files
getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from
having CRLF entries in text files.
> But before adding the .gitattributes file we need to normalize the existing tree, so
that people when they sync after .giattributes change wont end up with a bunch of modified
files in their workspace.
> I am adding a couple of links here to give more primer on what exactly is the issue and
how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
> I will submit a separate bug and patch for .gitattributes

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message