hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8589) ViewFs tests fail when tests and home dirs are nested
Date Mon, 15 Oct 2012 20:23:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476396#comment-13476396
] 

Sanjay Radia commented on HADOOP-8589:
--------------------------------------

bq. The idea of moving TestLFS into ViewFileSystemTestSetup ...
*Only* the trash tests use TestLFS -- TestLFS is not used in any of the other viewfs tests.
ViewFileSystemTestSetup should not be setting up things that only ONE of the many tests that
call it need.
Indeed TestLFS should move to a more general test-helper class because TestLFS is used in
non-viewfs test - the other test trash (e.g. TestTrash) has its own copy of TestLFS. 

But your fix to TestLFS to ensure that there is no accidental delete during a TestTrash of
home dirs is fine. I suggest we file a jira to make that change. If as part of that fix you
also want to create a common TestLFS (for viewfs tests and for TestTrash) then that also makes
sense.

At this stage I suggest we do the following
# file a jira to fix TestLFS - extract your fix from this patch in this jira.
# either 
** let a modified version of your patch without TestLFS go through and then I file another
Jira to get my patch through (since it does more cleanup) OR 
** just let my patch go through in

                
> ViewFs tests fail when tests and home dirs are nested
> -----------------------------------------------------
>
>                 Key: HADOOP-8589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, test
>    Affects Versions: 0.23.1, 2.0.0-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8589.patch, HADOOP-8589.patch, hadoop-8589-sanjay.patch,
HADOOP-8859.patch
>
>
> TestFSMainOperationsLocalFileSystem fails in case when the test root directory is under
the user's home directory, and the user's home dir is deeper than 2 levels from /. This happens
with the default 1-node installation of Jenkins. 
> This is the failure log:
> {code}
> org.apache.hadoop.fs.FileAlreadyExistsException: Path /var already exists as dir; cannot
create link here
> 	at org.apache.hadoop.fs.viewfs.InodeTree.createLink(InodeTree.java:244)
> 	at org.apache.hadoop.fs.viewfs.InodeTree.<init>(InodeTree.java:334)
> 	at org.apache.hadoop.fs.viewfs.ViewFileSystem$1.<init>(ViewFileSystem.java:167)
> 	at org.apache.hadoop.fs.viewfs.ViewFileSystem.initialize(ViewFileSystem.java:167)
> 	at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2094)
> 	at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:79)
> 	at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2128)
> 	at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2110)
> 	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:290)
> 	at org.apache.hadoop.fs.viewfs.ViewFileSystemTestSetup.setupForViewFileSystem(ViewFileSystemTestSetup.java:76)
> 	at org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem.setUp(TestFSMainOperationsLocalFileSystem.java:40)
> ...
> Standard Output
> 2012-07-11 22:07:20,239 INFO  mortbay.log (Slf4jLog.java:info(67)) - Home dir base /var/lib
> {code}
> The reason for the failure is that the code tries to mount links for both "/var" and
"/var/lib", and it fails for the 2nd one as the "/var" is mounted already.
> The fix was provided in HADOOP-8036 but later it was reverted in HADOOP-8129.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message