hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8608) Add Configuration API for parsing time durations
Date Wed, 10 Oct 2012 15:15:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473291#comment-13473291
] 

Robert Joseph Evans commented on HADOOP-8608:
---------------------------------------------

I like the latest patch and I am +1 on it assuming that test-patch comes back OK with it.

I don't really see much of a use case where the API would need to change. If I specify 1d3h2s
or 1.5 days in general with java I am probably going to be requesting the result in ms because
that is what most time oriented APIs in java take.  Perhaps seconds for a few configs because
that is the default units for the config.  Yes, the newer APIs take a TimeUnit as well but
why request it in days if I know it is going to lose precision and make it potentially harder
to write unit tests for? no one wants to wait around for 1 day in a unit test for something
to happen.

If someone really wants a more thorough format we can add it in in a separate JIRA so long
as it maintains backwards compatibility with the current format.
                
> Add Configuration API for parsing time durations
> ------------------------------------------------
>
>                 Key: HADOOP-8608
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8608
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Todd Lipcon
>            Priority: Minor
>         Attachments: 8608-0.patch, 8608-1.patch, 8608-2.patch
>
>
> Hadoop has a lot of configurations which specify durations or intervals of time. Unfortunately
these different configurations have little consistency in units - eg some are in milliseconds,
some in seconds, and some in minutes. This makes it difficult for users to configure, since
they have to always refer back to docs to remember the unit for each property.
> The proposed solution is to add an API like {{Configuration.getTimeDuration}} which allows
the user to specify the units with a postfix. For example, "10ms", "10s", "10m", "10h", or
even "10d". For backwards-compatibility, if the user does not specify a unit, the API can
specify the default unit, and warn the user that they should specify an explicit unit instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message