hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianbin Wei (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8776) Provide an option in test-patch that can enable / disable compiling native code
Date Mon, 01 Oct 2012 16:49:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466930#comment-13466930
] 

Jianbin Wei commented on HADOOP-8776:
-------------------------------------

Hemanth,

I agree that the core issue is the broken native compilation and that should be fixed.

My suggestion is to disable the native compilation for "all" broken platforms by default,
file tickets to have them fixed and enable native compilation as part of the fix.

My purpose is to make it more convenient/efficient for other developers.  

Every time I generate a patch, I do the patch test and it fails due to javac warning.  I had
to check if it is because of native compilation or not.   The whole process for compilation
and checking takes about 3 minutes. 

If we can save this 3 minutes for each patch/developer, we may easily save thousands of minutes
before the native compilation is fixed.  This should justify a slightly more complicated workaround
that may take you 60 minutes.

Just my 2 cents.

                
> Provide an option in test-patch that can enable / disable compiling native code
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-8776
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8776
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: HADOOP-8776.patch, HADOOP-8776.patch, HADOOP-8776.patch
>
>
> The test-patch script in Hadoop source runs a native compile with the patch. On platforms
like MAC, there are issues with the native compile that make it difficult to use test-patch.
This JIRA is to try and provide an option to make the native compilation optional. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message