hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8992) Enhance unit-test coverage of class HarFileSystem
Date Tue, 30 Oct 2012 18:14:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487083#comment-13487083
] 

Robert Joseph Evans commented on HADOOP-8992:
---------------------------------------------

Ivan,

I have a couple of comments about the code

# TestHarFileSystemBasics.java is missing an Apache License Header.  This needs to be added
in.
# There are many lines in TestHarFileSystemBasics.java that are over 80 characters.  The style
guidelines want us to wrap the line at 80 characters. Although we do make occasional exceptions,
it would be good to wrap as many of them as possible.
# In many of the negative test cases you are printing out the IOException that was caught.
 I think it would be better to actually log them instead.

The content of all of the tests look OK to me, but I am not an expert on HAR so if someone
else could take a look at the tests that would be great.
                
> Enhance unit-test coverage of class HarFileSystem
> -------------------------------------------------
>
>                 Key: HADOOP-8992
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8992
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ivan A. Veselovsky
>            Assignee: Ivan A. Veselovsky
>            Priority: Minor
>         Attachments: HADOOP-8992-branch-0.23--a.patch, HADOOP-8992-branch-2--a.patch
>
>
> New unit test TestHarFileSystem2 provided in order to enhance coverage of class HarFileSystem.
> Also some unused methods deleted from class HarFileSystem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message