hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-8977) multiple FsShell test failures on Windows
Date Tue, 30 Oct 2012 22:20:12 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Chris Nauroth updated HADOOP-8977:

    Attachment: HADOOP-8977-branch-trunk-win.patch

The attached patch fixes the tests.  The tests pass on both Mac and Windows.  There were 2
separate issues.

For TestFsShellReturnCode, it was another case of test code creating invalid test paths by
manually concatenating strings that mingle '/' and '\' as path separators.  These are all
fixed by switching to the Path constructor that takes parent and child explicitly as arguments.

For TestFsShellCopy, there was a bug in CommandWithDestination and its subclasses.  They were
using a PathData constructor that accepts a File object.  This constructor was meant to indicate
that the file's path is interpreted as local.  This doesn't work on Windows though, because
File.getPath() and File.toString() will convert '/' to '\', and the downstream code doesn't
expect this.  To fix this, I removed the dangerous PathData constructor.  Then, I switched
from private to public for the constructor that accepts a FileSystem argument.  Then, I changed
all call sites to use this constructor with a local FileSystem to preserve the semantics that
we are talking about local paths.  PathData is @InterfaceAudience.Private and @InterfaceStability.Unstable,
so I expect the interface change to be safe.

This change is dependent on HADOOP-8953, which also changes PathData.  My patch is relative
to that patch.

> multiple FsShell test failures on Windows
> -----------------------------------------
>                 Key: HADOOP-8977
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8977
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8977-branch-trunk-win.patch
> Multiple FsShell-related tests fail on Windows.  Commands are returning non-zero exit

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message