hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8608) Add Configuration API for parsing time durations
Date Tue, 09 Oct 2012 17:42:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472579#comment-13472579
] 

Robert Joseph Evans commented on HADOOP-8608:
---------------------------------------------

I like the new API.  I do have a few minor comments, none of which I see as blocking this
from going in.

The first is to not use StringBuilder for the warning.  It seems cleaner and more compact
to have 

{code}
LOG.warn("No unit for " + name + " (" + vStr +") assuming " 
  + unit);
{code} over {code}
StringBuilder sb = new StringBuilder("No unit for ")
  .append(name).append(" (").append(vStr).append(") assuming ")
  .append(unit.toString());
LOG.warn(sb.toString());
{code}

I would also like to see more lenient parsing, but that is something that can come later as
the need shows up.  I can see people wanting to write "1.5 days" over "36h".  But like I said
before this is not a big deal because "36h" is a whole lot easier to understand and less error
prone compared to 129600000.
                
> Add Configuration API for parsing time durations
> ------------------------------------------------
>
>                 Key: HADOOP-8608
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8608
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Todd Lipcon
>         Attachments: 8608-0.patch, 8608-1.patch
>
>
> Hadoop has a lot of configurations which specify durations or intervals of time. Unfortunately
these different configurations have little consistency in units - eg some are in milliseconds,
some in seconds, and some in minutes. This makes it difficult for users to configure, since
they have to always refer back to docs to remember the unit for each property.
> The proposed solution is to add an API like {{Configuration.getTimeDuration}} which allows
the user to specify the units with a postfix. For example, "10ms", "10s", "10m", "10h", or
even "10d". For backwards-compatibility, if the user does not specify a unit, the API can
specify the default unit, and warn the user that they should specify an explicit unit instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message