hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan A. Veselovsky (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HADOOP-8993) Remove unused methods from FileUtil class
Date Tue, 30 Oct 2012 11:14:13 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Ivan A. Veselovsky resolved HADOOP-8993.

    Resolution: Invalid

Accordingly to the last comment should not be done since the FileUtil is a public API. The
coverage need to be elevated by covering the unused methods with  unit tests.
> Remove unused methods from FileUtil class
> -----------------------------------------
>                 Key: HADOOP-8993
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8993
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ivan A. Veselovsky
>            Assignee: Ivan A. Veselovsky
>            Priority: Minor
>         Attachments: HADOOP-8993-branch-0.23.patch, HADOOP-8993-branch-2.patch
> Some methods in class org.apache.hadoop.fs.FileUtil are used neither in project code
nor in tests, that is, are a dead code. 
> This lowers the overall coverage of that class.
> The suggested patches remove the unused methods.
> Note: one of #copy(5) method is unused in 0.23 branch, while is used in branch-2, so
the patches for these branches are different.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message