hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8933) test-patch.sh fails erroneously on platforms that can't build native
Date Tue, 16 Oct 2012 16:49:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477146#comment-13477146
] 

Chris Nauroth commented on HADOOP-8933:
---------------------------------------

Currently, I see this problem on Mac OS X due to native code incompatibilities, like HADOOP-7147.

The root cause is that when the script pre-builds the existing trunk code, it does not use
-Pnative, but when it builds after applying the patch, it does use -Pnative.  Note that we
don't want to remove -Pnative completely, because that was added to fix a bug reported in
HADOOP-8488.  Instead, if we provided an additional optional flag for developers to disable
the native portion of the build, then it would still catch problems in the native code by
default, but developers on non-compatible platforms would still have a way to use test-patch.sh
as long as they are not working on the native code.

                
> test-patch.sh fails erroneously on platforms that can't build native
> --------------------------------------------------------------------
>
>                 Key: HADOOP-8933
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8933
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>
> If a developer is working on a platform that can't build native (like OS X right now),
then test-patch.sh will report the patch as a failure due to "The patch appears to cause the
build to fail."  This is incorrect, because the developer's patch didn't cause the build to
fail.  Adding an extra optional flag to test-patch.sh would help developers on these platforms.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message