hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8912) adding .gitattributes file to prevent CRLF and LF mismatches for source and text files
Date Thu, 11 Oct 2012 22:01:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474545#comment-13474545
] 

Aaron T. Myers commented on HADOOP-8912:
----------------------------------------

Maybe I'm missing something, but I don't see how this will actually prevent CRLF and LF files
from getting checked in to the repo, since actual commits/merges are done via svn, not git.
The svn repo is mirrored to a git repo, but that repo is read only.
                
> adding .gitattributes file to prevent CRLF and LF mismatches for source and text files
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8912
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8912
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.0-alpha, 1-win
>            Reporter: Raja Aluri
>         Attachments: HADOOP-8912.branch-1-win.patch, HADOOP-8912.branch-2.patch, HADOOP-8912.trunk.patch
>
>
> Source code in hadoop-common repo has a bunch of files that have CRLF endings.
> With more development happening on windows there is a higher chance of more CRLF files
getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from
having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and
how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>  
> This issue for adding .gitattributes file to the tree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message