hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8912) adding .gitattributes file to prevent CRLF and LF mismatches for source and text files
Date Thu, 11 Oct 2012 03:29:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473805#comment-13473805
] 

Hadoop QA commented on HADOOP-8912:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548647/HADOOP-8912.trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1606//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1606//console

This message is automatically generated.
                
> adding .gitattributes file to prevent CRLF and LF mismatches for source and text files
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8912
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8912
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1-win
>            Reporter: Raja Aluri
>             Fix For: 1-win
>
>         Attachments: HADOOP-8912.branch-1-win.patch, HADOOP-8912.branch-2.patch, HADOOP-8912.trunk.patch
>
>
> Source code in hadoop-common repo has a bunch of files that have CRLF endings.
> With more development happening on windows there is a higher chance of more CRLF files
getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from
having CRLF entries in text files.
> I am adding a couple of links here to give more primer on what exactly is the issue and
how we are trying to fix it.
> # http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
> # http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
>  
> This issue for adding .gitattributes file to the tree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message