hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9000) remove Trash.makeTrashRelativePath in branch-1-win
Date Wed, 31 Oct 2012 23:33:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488360#comment-13488360
] 

Suresh Srinivas commented on HADOOP-9000:
-----------------------------------------

Nice jira number :-)

I am not sure if this change adds much value in the way of cleanup.
                
> remove Trash.makeTrashRelativePath in branch-1-win
> --------------------------------------------------
>
>                 Key: HADOOP-9000
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9000
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: trash
>    Affects Versions: 1-win
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HADOOP-9000.branch-1-win.patch
>
>
> This method does nothing except calling Path.mergePaths(). If the method is used to show
the purpose of the operation, comment can do as well since it's used only in a couple places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message