hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
Date Tue, 09 Oct 2012 23:26:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472857#comment-13472857
] 

Alejandro Abdelnur commented on HADOOP-8887:
--------------------------------------------


* Unless I'm missing something, I don't see patch anything like the following to define defaults:

{code}
     * @parameter  expression="${source}" default-value="${basedir}/src/main/native"
     * @parameter  expression="${output}" default-value="${project.build.directory}/native"
{code}

* CleanMojo for windows, I don't see how, but if that is the case we should introduce it then
if needed, not now just in case.

* generate/make, I'd merge them in a single Mojo as there are not usecases for using them
apart, plus generate does not generate sources but make files.

* where test code lives? does compiled test stuff need to be segregated in target/test-native?

As an additional reason for removing clean & merging generate/make is that the amount
of plugins config in the POMs are reduced from 3 to 1.

I have not run the patch yet, but I assume that ALL generated/created files are done under
output and the source tree is not polluted with files created at build time.


                
> Use a Maven plugin to build the native code using CMake
> -------------------------------------------------------
>
>                 Key: HADOOP-8887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8887
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch,
HADOOP-8887.004.patch
>
>
> Currently, we build the native code using ant-build invocations.  Although this works,
it has some limitations:
> * compiler warning messages are hidden, which can cause people to check in code with
warnings unintentionally
> * there is no framework for running native unit tests; instead, we use ad-hoc constructs
involving shell scripts
> * the antrun code is very platform specific
> * there is no way to run a specific native unit test
> * it's more or less impossible for scripts like test-patch.sh to separate a native test
failing from the build itself failing (no files are created) or to enumerate which native
tests failed.
> Using a native Maven plugin would overcome these limitations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message