hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8910) Add examples to GlobExpander#expand method
Date Thu, 11 Oct 2012 05:45:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473860#comment-13473860

Suresh Srinivas commented on HADOOP-8910:

@Eli thanks.

bq. Nice addition, but are you sure the examples work? Historically I've seen exceptions if
a curly-braced list contains a /. Also, some of the expansion look wrong, at least with respect
to the shell. Ex. "{a/b,c/d,{e,f}} - a/b, c/d, {e,f}" should expand as "a/b, c/d, e, f"
Daryn, I cannot be wrong :-)

I just took it out of TestGlobExpander#testExpansion(). The document could be even better
with perhaps more examples. But this is a good start.
> Add examples to GlobExpander#expand method
> ------------------------------------------
>                 Key: HADOOP-8910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8910
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Minor
>         Attachments: HADOOP-8910.patch
> Every time I review code related to glob I end up having to relearn how the code works.
Adding few examples should help understand some of this code better.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message