hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianbin Wei (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8776) Provide an option in test-patch that can enable / disable compiling native code
Date Wed, 03 Oct 2012 17:44:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468698#comment-13468698
] 

Jianbin Wei commented on HADOOP-8776:
-------------------------------------

{quote}
Now test-patch will be platform specific. Ideally, it must be tested on all platforms before
committing.
{quote}

Yes I agree completely.  As you said, the core is to fix it on "broken" platforms.  This is
just a workaround.

{quote}
It has more logic (either --enable-native is passed OR it is a supported platform, etc.).
Not earth-shattering, but still needs to be understood in context by someone fresh looking
at it.
{quote}

I would say only the developer to fix the script will need to understand the extra complexity.
 So it should be transparent to most other developers.  

{quote}
The dependency it will put on us to have to track removing this once native compile is fixed.
Given that we cannot rely on contributors being always there and watchful, I am worried that
someone will forget to document in a related JIRA to fix test-patch and we will end up in
a situation that native compile is fixed, and test-patch isn't testing it.
{quote}

The developer who disables the test needs to 
* file a ticket to get "broken" platform fixed (if it is not there yet) AND 
* document the needs to enable the test in the ticket.  In this case if it would be you :-)

Can you also print some messages to notify others that the native compilation is disabled
due to issues?

My goal is to provide best experiences for both end users and developers.

Other thoughts?
                
> Provide an option in test-patch that can enable / disable compiling native code
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-8776
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8776
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: HADOOP-8776.patch, HADOOP-8776.patch, HADOOP-8776.patch
>
>
> The test-patch script in Hadoop source runs a native compile with the patch. On platforms
like MAC, there are issues with the native compile that make it difficult to use test-patch.
This JIRA is to try and provide an option to make the native compilation optional. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message