hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8567) Backport conf servlet with dump running configuration to branch 1.x
Date Fri, 26 Oct 2012 17:17:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485057#comment-13485057
] 

Suresh Srinivas commented on HADOOP-8567:
-----------------------------------------

I do not see these changes from HADOOP-6408. Are they not relevant? Rest of the porting looks
good.
{noformat}
diff --git src/java/org/apache/hadoop/conf/Configuration.java src/java/org/apache/hadoop/conf/Configuration.java
index e5a4523..7407d8b 100644
--- src/java/org/apache/hadoop/conf/Configuration.java
+++ src/java/org/apache/hadoop/conf/Configuration.java
@@ -68,6 +70,7 @@ import org.apache.hadoop.util.ReflectionUtils;
 +410,8 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
      if (other.overlay!=null) {
        this.overlay = (Properties)other.overlay.clone();
      }
+
+     this.updatingResource = new HashMap<String, String>(other.updatingResource);
    }
    
     this.finalParameters = new HashSet<String>(other.finalParameters);
@@ -604,6 +593,7 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
     if (!isDeprecated(name)) {
       getOverlay().setProperty(name, value);
       getProps().setProperty(name, value);
+      updatingResource.put(name, UNKNOWN_RESOURCE);
     }
     else {
       DeprecatedKeyInfo keyInfo = deprecatedKeyMap.get(name);
@@ -1438,9 +1426,7 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
       if (finalParameters.contains(oldKey)) {
         finalParameters.remove(oldKey);
       }
-      if (storeResource) {
-        updatingResource.remove(oldKey);
-      }
+      updatingResource.remove(oldKey);
     }
   }
   
@@ -1464,9 +1450,7 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
         continue;
       }
       properties.setProperty(key, value);
-      if (storeResource) {
-        updatingResource.put(key, updatingResource.get(attr));
-      }
+      updatingResource.put(key, updatingResource.get(attr));
       if (finalParameter) {
         finalParameters.add(key);
       }
{noformat}
                
> Backport conf servlet with dump running configuration to branch 1.x
> -------------------------------------------------------------------
>
>                 Key: HADOOP-8567
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8567
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: conf
>    Affects Versions: 1.0.0
>            Reporter: Junping Du
>            Assignee: Jing Zhao
>         Attachments: Hadoop.8567.branch-1.001.patch, Hadoop.8567.branch-1.002.patch
>
>
> HADOOP-6408 provide conf servlet that can dump running configuration which great helps
admin to trouble shooting the configuration issue. However, that patch works on branch after
0.21 only and should be backport to branch 1.x.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message