hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8922) Provide alternate JSONP output for JMXJsonServlet to allow javascript in browser dashboard
Date Sat, 13 Oct 2012 23:06:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475727#comment-13475727
] 

Hadoop QA commented on HADOOP-8922:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12549034/HADOOP-8922-1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

      {color:red}-1 javac{color}.  The applied patch generated 2044 javac compiler warnings
(more than the trunk's current 2043 warnings).

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1624//testReport/
Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1624//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1624//console

This message is automatically generated.
                
> Provide alternate JSONP output for JMXJsonServlet to allow javascript in browser dashboard
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8922
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8922
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Damien Hardy
>            Priority: Trivial
>              Labels: newbie, patch
>         Attachments: HADOOP-8922-1.patch, test.html
>
>
> JMXJsonServlet may provide a JSONP alternative to JSON to allow javascript in browser
GUI to make requests.
> For security purpose about XSS, browser limit request on other domain[¹|#ref1] so that
metrics from cluster nodes cannot be used in a full js interface.
> An example of this kind of dashboard is the bigdesk[²|#ref2] plugin for ElasticSearch.
> In order to achieve that the servlet should detect a GET parameter (callback=xxxx) and
modify the response by surrounding the Json value with "xxxx(" and ");" [³|#ref3]
> value "xxxx" is variable and should be provide by client as callback parameter value.
> {anchor:ref1}[1] https://developer.mozilla.org/en-US/docs/Same_origin_policy_for_JavaScript
> {anchor:ref2}[2] https://github.com/lukas-vlcek/bigdesk
> {anchor:ref3}[3] http://en.wikipedia.org/wiki/JSONP

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message