Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8CA00D12D for ; Wed, 5 Sep 2012 05:12:08 +0000 (UTC) Received: (qmail 62347 invoked by uid 500); 5 Sep 2012 05:12:08 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 62257 invoked by uid 500); 5 Sep 2012 05:12:08 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 62200 invoked by uid 99); 5 Sep 2012 05:12:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2012 05:12:07 +0000 Date: Wed, 5 Sep 2012 16:12:07 +1100 (NCT) From: "Hemanth Yamijala (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <514288677.37470.1346821927721.JavaMail.jiratomcat@arcas> In-Reply-To: <88385754.37346.1346820547505.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HADOOP-8765) LocalDirAllocator.ifExists API is broken and unused MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448487#comment-13448487 ] Hemanth Yamijala commented on HADOOP-8765: ------------------------------------------ BTW, all other calls to LocalDirAllocator first call AllocatorPerContext.confChanged, that is responsible for initialising the localDirsPath. Inserting that call fixes the NullPointerException. > LocalDirAllocator.ifExists API is broken and unused > --------------------------------------------------- > > Key: HADOOP-8765 > URL: https://issues.apache.org/jira/browse/HADOOP-8765 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Reporter: Hemanth Yamijala > Assignee: Hemanth Yamijala > Priority: Minor > > LocalDirAllocator.ifExists calls AllocatorPerContext.ifExists, which accesses the localDirsPath variable that is uninitialised. Hence, any code that uses this API is likely to fail with a NullPointerException. > However, this API is currently not used anywhere else in trunk. The earlier usage was in IsolationRunner, that has since been removed via MAPREDUCE-2606. > Hence, we could remove this API for trunk, and if required, fix it for the 1.x branch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira