Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 28 Sep 2012 00:22:08 +1100 (NCT)
From: "Daryn Sharp (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <1370026167.133652.1348752128369.JavaMail.jiratomcat@arcas>
In-Reply-To: <890185410.128741.1348672027879.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HADOOP-8852) DelegationTokenRenewer thread is
 not stopped when its filesystem is closed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464708#comment-13464708 ] 

Daryn Sharp commented on HADOOP-8852:
-------------------------------------

Hmm.  I think we may have regressed functionality because I thought I Nicholas and I added lazy start to the renewer when the first token is added.  While a little bit larger in scope, and it's something I've always been meaning to do, I'd suggest the renewer should:
* be a singleton to avoid multiple threads
* lazy starts when a token is added
* filesystem won't explicitly start the renewer or join with it
* when hftp or webhdfs is closed, it should cancel the token if {{initDelegationToken}} had to create a token
* the cancel methods should tell the renewer to stop renewing the canceled token.  perhaps the renewer should be the one to cancel the token to avoid race conditions (fs cancels just before the renewer tries to renew)
* the renewer should shutdown if it runs out of tokens
                
> DelegationTokenRenewer thread is not stopped when its filesystem is closed
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-8852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8852
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Tom White
>            Assignee: Karthik Kambatla
>         Attachments: hadoop-8852.patch, hadoop-8852.patch
>
>
> HftpFileSystem and WebHdfsFileSystem should stop the DelegationTokenRenewer thread when they are closed. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira