hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
Date Wed, 05 Sep 2012 09:05:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448581#comment-13448581
] 

Hadoop QA commented on HADOOP-8749:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12543827/HADOOP-8749_rev3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1402//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1402//console

This message is automatically generated.
                
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8749
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8749
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>         Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch,
HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream
uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the
implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there
is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message