hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8765) LocalDirAllocator.ifExists API is broken and unused
Date Wed, 05 Sep 2012 09:43:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448599#comment-13448599
] 

Hadoop QA commented on HADOOP-8765:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12543815/HADOOP-8765.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1404//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1404//console

This message is automatically generated.
                
> LocalDirAllocator.ifExists API is broken and unused
> ---------------------------------------------------
>
>                 Key: HADOOP-8765
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8765
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: HADOOP-8765.patch
>
>
> LocalDirAllocator.ifExists calls AllocatorPerContext.ifExists, which accesses the localDirsPath
variable that is uninitialised. Hence, any code that uses this API is likely to fail with
a NullPointerException.
> However, this API is currently not used anywhere else in trunk. The earlier usage was
in IsolationRunner, that has since been removed via MAPREDUCE-2606.
> Hence, we could remove this API for trunk, and if required, fix it for the 1.x branch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message