hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8765) LocalDirAllocator.ifExists API is broken and unused
Date Wed, 05 Sep 2012 09:48:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448603#comment-13448603
] 

Hemanth Yamijala commented on HADOOP-8765:
------------------------------------------

bq. -1 tests included. The patch doesn't appear to include any new or modified tests.
bq. Please justify why no new tests are needed for this patch.
bq. Also please list what manual steps were performed to verify this patch.

The patch removes code. Hence, no new tests.
                
> LocalDirAllocator.ifExists API is broken and unused
> ---------------------------------------------------
>
>                 Key: HADOOP-8765
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8765
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: HADOOP-8765.patch
>
>
> LocalDirAllocator.ifExists calls AllocatorPerContext.ifExists, which accesses the localDirsPath
variable that is uninitialised. Hence, any code that uses this API is likely to fail with
a NullPointerException.
> However, this API is currently not used anywhere else in trunk. The earlier usage was
in IsolationRunner, that has since been removed via MAPREDUCE-2606.
> Hence, we could remove this API for trunk, and if required, fix it for the 1.x branch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message