hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8821) Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Date Sun, 16 Sep 2012 22:18:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456692#comment-13456692
] 

Hadoop QA commented on HADOOP-8821:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12545349/HADOOP-8821.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1477//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1477//console

This message is automatically generated.
                
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a
loop
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8821
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8821
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Trivial
>         Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use
StringBuilder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message