hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8776) Provide an option in test-patch that can enable / disable compiling native code
Date Wed, 26 Sep 2012 16:03:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463916#comment-13463916
] 

Hemanth Yamijala commented on HADOOP-8776:
------------------------------------------

bq. And default it to true on Linux, and false on MacOS? You can use uname to find the operating
system name in the script. What do you think?

Given that you are fixing the native build, I assume we would like to enable native compile
by default on MacOS too after that. Given that, I feel like leaving it enabled by default
like in the last patch. 

We can remove the hint, I agree that it seems out of place. If the developer gets a failure
due to native build, he could probably look at the test-patch script to see if there's an
option to turn it off and find it. We could probably also document it on Wiki etc.

Feels like this would be an option to keep things going for now, and not need any further
changes once things get better with the native build. Thoughts ?
                
> Provide an option in test-patch that can enable / disable compiling native code
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-8776
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8776
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: HADOOP-8776.patch, HADOOP-8776.patch
>
>
> The test-patch script in Hadoop source runs a native compile with the patch. On platforms
like MAC, there are issues with the native compile that make it difficult to use test-patch.
This JIRA is to try and provide an option to make the native compilation optional.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message