hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8776) Provide an option in test-patch that can enable / disable compiling native code
Date Wed, 26 Sep 2012 17:01:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463954#comment-13463954
] 

Colin Patrick McCabe commented on HADOOP-8776:
----------------------------------------------

bq. Given that you are fixing the native build, I assume we would like to enable native compile
by default on MacOS too after that. Given that, I feel like leaving it enabled by default
like in the last patch.

I would certainly like to review patches or suggest approaches to fix to the native Mac build.
 However, HADOOP-8744 is currently not assigned to me.  It's not likely to be me personally
who fixes it because I don't have a Mac :)

Since MacOS is a POSIX platform, we generally try to support it by making our native code
POSIX-compliant (or at least able to work under POSIX when advanced features are not detected.)

bq. Feels like this would be an option to keep things going for now, and not need any further
changes once things get better with the native build. Thoughts ?

Sounds reasonable to me.  My main objection to the previous patch was the hint text, as I
said.
                
> Provide an option in test-patch that can enable / disable compiling native code
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-8776
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8776
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: HADOOP-8776.patch, HADOOP-8776.patch
>
>
> The test-patch script in Hadoop source runs a native compile with the patch. On platforms
like MAC, there are issues with the native compile that make it difficult to use test-patch.
This JIRA is to try and provide an option to make the native compilation optional. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message