hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8151) Error handling in snappy decompressor throws invalid exceptions
Date Sun, 23 Sep 2012 10:01:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461358#comment-13461358
] 

Hadoop QA commented on HADOOP-8151:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12546191/HADOOP-8151.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1504//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1504//console

This message is automatically generated.
                
> Error handling in snappy decompressor throws invalid exceptions
> ---------------------------------------------------------------
>
>                 Key: HADOOP-8151
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8151
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io, native
>    Affects Versions: 1.0.2, 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Matt Foley
>             Fix For: 1.0.3
>
>         Attachments: HADOOP-8151-branch-1.0.patch, HADOOP-8151.patch, HADOOP-8151.patch
>
>
> SnappyDecompressor.c has the following code in a few places:
> {code}
>     THROW(env, "Ljava/lang/InternalError", "Could not decompress data. Buffer length
is too small.");
> {code}
> this is incorrect, though, since the THROW macro doesn't need the "L" before the class
name. This results in a ClassNotFoundException for Ljava.lang.InternalError being thrown,
instead of the intended exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message