Return-Path: 
 <common-issues-return-35549-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 55218D6C6
	for <apmail-hadoop-common-issues-archive@minotaur.apache.org>;
 Mon, 27 Aug 2012 16:10:08 +0000 (UTC)
Received: (qmail 26116 invoked by uid 500); 27 Aug 2012 16:10:08 -0000
Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org
Received: (qmail 26018 invoked by uid 500); 27 Aug 2012 16:10:08 -0000
Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:common-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:common-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:common-issues@hadoop.apache.org>
List-Id: <common-issues.hadoop.apache.org>
Reply-To: common-issues@hadoop.apache.org
Delivered-To: mailing list common-issues@hadoop.apache.org
Received: (qmail 25967 invoked by uid 99); 27 Aug 2012 16:10:07 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Aug 2012 16:10:07 +0000
Date: Tue, 28 Aug 2012 03:10:07 +1100 (NCT)
From: "Robert Joseph Evans (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <1943143233.1773.1346083807927.JavaMail.jiratomcat@arcas>
In-Reply-To: <522565281.6890.1345749402417.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (HADOOP-8724) Add improved APIs for globbing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HADOOP-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8724:
----------------------------------------

    Attachment: HADOOP-8724.txt

I like the points that have been made so far, but I would prefer to discuss a real API over a theoretical one.  The implementation still needs a lot of work but the existing tests so far pass.

I am mostly interested in feedback about the APIs themselves.

In general there is a Glob class.  It is made up of a path and a pattern.  The Path is optional.  If the Path was supplied and does not exist an exception will be thrown.  The pattern is required.  A Glob can also be created from just a Path, but that is mostly for backwards compatibility.  In most cases I would expect a Glob to be created with just a pattern.

The result of running a glob is a GlobResult which is a RemoteIterator<FileStatus>, but also provides some extra APIs so that someone can easily tell if nothing matched the glob, or (and this this impl is a real hack right now) the glob looked more like a path then a glob.  This is only really needed by PathData so the shell can adjust the error message appropriately.
                
> Add improved APIs for globbing
> ------------------------------
>
>                 Key: HADOOP-8724
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8724
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8724.txt
>
>
> After the discussion on HADOOP-8709 it was decided that we need better APIs for globbing to remove some of the inconsistencies with other APIs.  Inorder to maintain backwards compatibility we should deprecate the existing APIs and add in new ones.
> See HADOOP-8709 for more information about exactly how those APIs should look and behave.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira