Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69FF8D08D for ; Wed, 29 Aug 2012 01:47:09 +0000 (UTC) Received: (qmail 50737 invoked by uid 500); 29 Aug 2012 01:47:09 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 50693 invoked by uid 500); 29 Aug 2012 01:47:09 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 50633 invoked by uid 99); 29 Aug 2012 01:47:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2012 01:47:08 +0000 Date: Wed, 29 Aug 2012 12:47:08 +1100 (NCT) From: "Colin Patrick McCabe (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1309726659.9861.1346204828938.JavaMail.jiratomcat@arcas> In-Reply-To: <1372169749.3898.1346108467517.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HADOOP-8737) cmake: always use JAVA_HOME to find libjvm.so, jni.h, jni_md.h MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443731#comment-13443731 ] Colin Patrick McCabe commented on HADOOP-8737: ---------------------------------------------- I am going to post a new version of the patch that surrounds this code in {code} IF("${CMAKE_SYSTEM}" MATCHES "Linux") {code} On non-Linux platforms, we can fall back on the old method of detecting JNI installations. Allen, I believe this will address your concerns. > cmake: always use JAVA_HOME to find libjvm.so, jni.h, jni_md.h > -------------------------------------------------------------- > > Key: HADOOP-8737 > URL: https://issues.apache.org/jira/browse/HADOOP-8737 > Project: Hadoop Common > Issue Type: Bug > Components: native > Affects Versions: 2.2.0-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HADOOP-8737.001.patch > > > We should always use the {{libjvm.so}}, {{jni.h}}, and {{jni_md.h}} under {{JAVA_HOME}}, rather than trying to look for them in system paths. Since we compile with Maven, we know that we'll have a valid {{JAVA_HOME}} at all times. There is no point digging in system paths, and it can lead to host contamination if the user has multiple JVMs installed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira