hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8737) cmake: always use JAVA_HOME to find libjvm.so, jni.h, jni_md.h
Date Wed, 29 Aug 2012 00:48:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443699#comment-13443699
] 

Allen Wittenauer commented on HADOOP-8737:
------------------------------------------

You'll note that I'm not giving any official vote on it.  Commit or not, I don't really care.
 Just pointing out that this is another portability break in case someone cares.

As my patches, I've posted several variations of various parts of my portability patches over
the years. I really have no intention at the time of this writing to expend the effort to
update them on JIRA again.  While "patches accepted" is the common mantra, "patches committed"
is not. I don't have someone who I sit next to that I can tap on the shoulder and blanket
+1 them, especially since portability work is tricky and there are lots of subtle bugs.  (For
example, the group code in libhadoop on OS X is quite entertaining...)

In the case of this one, like a lot of the other patches that blatantly break any attempts
at portability, I'll just rip it out and replace with my own code. I already replace other
parts of the system with more functional equivalents (like the krb5 filter...) so one more
isn't going to hurt.


                
> cmake: always use JAVA_HOME to find libjvm.so, jni.h, jni_md.h
> --------------------------------------------------------------
>
>                 Key: HADOOP-8737
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8737
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-8737.001.patch
>
>
> We should always use the {{libjvm.so}}, {{jni.h}}, and {{jni_md.h}} under {{JAVA_HOME}},
rather than trying to look for them in system paths.  Since we compile with Maven, we know
that we'll have a valid {{JAVA_HOME}} at all times.  There is no point digging in system paths,
and it can lead to host contamination if the user has multiple JVMs installed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message