hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8736) Create a Builder to make an RPC server
Date Tue, 28 Aug 2012 17:16:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443285#comment-13443285
] 

Aaron T. Myers commented on HADOOP-8736:
----------------------------------------

I see your points, but I'd still prefer to have the truly required fields in the constructor.
That way, if we later add another required field, developers' IDEs will pick this up or it
will be seen at compile time, instead of waiting for a RTE like NPE or some specific exception
we put in the build() method. For what are truly required fields, it seems strictly better
to me to catch this at compile time instead of later.

I don't feel super strongly about this. Feel free to roll with whatever you'd prefer.
                
> Create a Builder to make an RPC server
> --------------------------------------
>
>                 Key: HADOOP-8736
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8736
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HADOOP-8736.patch, HADOOP-8736.patch
>
>
> There are quite a few variants of getServer() method to create an RPC server. Create
a builder class to abstract the building steps and avoid more getServer() variants in the
future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message