hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8689) Make trash a server side configuration option
Date Thu, 16 Aug 2012 22:50:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436388#comment-13436388
] 

Aaron T. Myers commented on HADOOP-8689:
----------------------------------------

Patch looks pretty good to me. Three small comments:

# Unless I'm missing something, it seems like moving the configuration of the client-side
emptier interval (not deletion interval) into TrashPolicyDefault#initialize is an unrelated
change, given that it's still configured via the client-side conf only. If I'm right about
that, seems like it should be done as a separate change, (or perhaps not done at all; it makes
sense to me that the emptier interval would be configured only in the Emptier class.)
# One too many "is": "If zero, trash emptying is is disabled."
# In the tests, I recommend you make a copy of the Configuration object before checking the
client side value, to ensure there's no issue with the configuration references in fact referring
to the same object between the client and server. (I don't think there is such a problem,
but making a copy of the conf object will make the test a little more robust to this sort
of issue.)
                
> Make trash a server side configuration option
> ---------------------------------------------
>
>                 Key: HADOOP-8689
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8689
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-8689.txt
>
>
> Per ATM's suggestion in HADOOP-8598 for v2 let's make {{fs.trash.interval}} configured
server side. If it is not configured server side then the client side configuration is used.
The {{fs.trash.checkpoint.interval}} option is already server side as the emptier runs in
the NameNode. Clients may manually run an emptier via hadoop org.apache.hadoop.fs.Trash but
it's OK if it uses a separate interval. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message