hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on EOF
Date Tue, 21 Aug 2012 13:57:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438740#comment-13438740
] 

Hudson commented on HADOOP-8614:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1173 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1173/])
    HADOOP-8614. IOUtils#skipFully hangs forever on EOF. Contributed by Colin Patrick McCabe
(Revision 1375216)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1375216
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java

                
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
>                 Key: HADOOP-8614
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8614
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
>   public static void skipFully(InputStream in, long len) throws IOException {
>     while (len > 0) {
>       long ret = in.skip(len);
>       if (ret < 0) {
>         throw new IOException( "Premature EOF from inputStream");
>       }
>       len -= ret;
>     }
>   }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event
of EOF.  However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they
both simply return 0 on EOF (no exception).  So it seems safe to assume that this is the standard
Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message